Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue72 Deprecate Add<T> method in favor of Set<T> #136

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Issue72 Deprecate Add<T> method in favor of Set<T> #136

wants to merge 6 commits into from

Conversation

matthew-p
Copy link

@matthew-p matthew-p commented Sep 27, 2020 •
edited
Loading

An attempt to address issue # 72, deprecating the IAppCache.Add(...) method with a .Set() method

Replaces the functionality as-is, adds [Obsolete] attributes to the Add method, and a unit test to confirm that all classes implementing IAppCache have an Obsolete attribute on their Add method

#72

alastairtree
alastairtree approved these changes Sep 27, 2020
View reviewed changes
Copy link
Owner

@alastairtree alastairtree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you. Will leave this here until i have setup a branch for the 3.0 changes. Thanks!

@alastairtree alastairtree added this to the 3.0 milestone Sep 27, 2020
@jnyrup
Copy link
Contributor

jnyrup commented Sep 27, 2020

Tip:
To prevent IntelliSense from suggestion both Set and Add you can add [EditorBrowsable(EditorBrowsableState.Never)] to the obsolete methods.

@alastairtree
Copy link
Owner

Tip:
To prevent IntelliSense from suggestion both Set and Add you can add [EditorBrowsable(EditorBrowsableState.Never)] to the obsolete methods.

Did not know that, very useful! Let's use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alastairtree alastairtree alastairtree approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@matthew-p @jnyrup @alastairtree